Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced project view; removed AdminLTE #1246

Merged
merged 48 commits into from
Jul 1, 2016
Merged

Conversation

55
Copy link
Contributor

@55 55 commented Jun 30, 2016

Closes #1209
Closes #1211
Closes #1172
Closes #353

Proposed changes:

  • Removed AdminLTE and all related code and functionality
  • Removed Sidebar
  • Moved all links to navbar
  • ...

@55 55 added the WIP label Jun 30, 2016
@55 55 added this to the Sprint 25 milestone Jun 30, 2016
@55 55 added the in progress label Jun 30, 2016
@55 55 removed the WIP label Jul 1, 2016
@55
Copy link
Contributor Author

55 commented Jul 1, 2016

@apinf/developers, @apinf/design, please review.

@jykae
Copy link
Contributor

jykae commented Jul 1, 2016

Overall, I think colors could be a bit softer for eye.
Maybe we could find something help from Google: https://www.google.fi/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=design+color+schemes

For example:
nayttokuva 2016-07-01 kello 11 52 19

Bright light blue on white background is not good combination,
nayttokuva 2016-07-01 kello 11 54 32

Search button style not same size with search box, maybe it could be also different color.
Same thing everywhere where search box is appearing.

nayttokuva 2016-07-01 kello 11 30 45

Last but not least:
Not related on this PR, but our search page was reactive previously, now it works from top navigation and from front page, but search page itself adds empty query string. It seems to broken in nightly as well.. Is there issue raised already?

@55
Copy link
Contributor Author

55 commented Jul 1, 2016

I agree on color schema.
We can make it better. But let's create a separate task for it.
For now I have changed it based on your feedback.

I have tested it in Firefox, Chrome, Edge, IE on Windows 10, search button looks good.
I think it's Safari bug, will try to fix it anyway.

Since search page reactivity bug already exists in the develop, let's resolve it in the separate issue.

@jykae
Copy link
Contributor

jykae commented Jul 1, 2016

Mobile view, search box jumps on another row, what you think of it?
nayttokuva 2016-07-01 kello 12 54 11

@jykae
Copy link
Contributor

jykae commented Jul 1, 2016

@NNN I merge this, let's do further design improvements on other tasks.

@jykae jykae merged commit b7c2d7c into develop Jul 1, 2016
@jykae jykae deleted the feature/remove-adminlte branch July 1, 2016 11:40
@jykae jykae removed the in progress label Jul 1, 2016
@brylie
Copy link
Contributor

brylie commented Jul 1, 2016

A quick note about color contrast is to aim for WCAG AA rating at the least, AAA if possible:
http://webaim.org/resources/contrastchecker/

@55 55 assigned jykae Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants