Another solution for missing API keys #1247
Conversation
|
Based on discussion after today's daily: On profile page I propose separate section for each proxy, as we are going towards multiproxy support, currently only API Umbrella section. |
| @@ -16,6 +16,9 @@ | |||
| "signUp": "Sign Up", | |||
| "apiCatalogue": "API Catalogue", | |||
| "profile": "Profile", | |||
| "profile_usernameIsTaken": "Username is already taken", | |||
| "profile_UmbrellaHeader": "API Umbrella", | |||
There was a problem hiding this comment.
Camel case starts with lowercase in most other keys. Change for consistency.
profile_umbrellaHeader
|
@brylie Requested fixes done. Could you help with the clipboard, thanks. |
|
When clicking 'Finish', the settings wizard has a noticeable delay, e.g. 2-3 seconds. Has the form submit hook logic changed? Perhaps route the user before doing API Umbrella related steps. |
|
When clicking "Get API Key for Umbrella" there is a significant delay with no indication that anything is happening. Lets add a spinner or some other indicator, e.g. grey out the button, so that the user does not grow impatient or become confused. |
|
Haven't touched it, could be another thing |
|
Since we are working with the Profile component, it is a good opportunity to move it to the root level. This is what we have done with the catalogue, bookmarks, ratings, and API Backends. I.e. we are incrementally refactoring our project to have components at the root level. |
|
Please pull changes before making any other changes. I refactored the code by moving the profile code to a 'users' component. |
| "profile_apiKey_copyButtonText": "Copy API key", | ||
| "profile_apiKey_copySuccessful": "API key copied to clipboard.", | ||
| "profile_usernameIsTaken": "Username is already taken", | ||
| "profile_umbrellaHeader": "API Umbrella", |
There was a problem hiding this comment.
We should probably make this text more generic. E.g. API Key(s). This is similar to how we don't use the word "Swagger" when referring to API Docs.
…o bugfix/empty-api-key-anothersolution
|
@brylie we are done. |
Closes #1216
Proposed changes