Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disable API key field #1342

Merged
merged 4 commits into from
Jul 28, 2016
Merged

Fix disable API key field #1342

merged 4 commits into from
Jul 28, 2016

Conversation

jykae
Copy link
Contributor

@jykae jykae commented Jul 25, 2016

Closes #622

Proposed changes

  • fix form to have "disable_api_key" under Settings object & correct field type (Boolean -> String)
  • allow 3 options that Umbrella expects for "disable_api_key" field

@jykae jykae added this to the Sprint 27 milestone Jul 25, 2016
@jykae
Copy link
Contributor Author

jykae commented Jul 25, 2016 •
edited

@apinf/developers @NNN please review, field should work now, place in form & style possibly need some fix.

@55 55 self-assigned this Jul 26, 2016
@55 55 merged commit 8d9d470 into develop Jul 28, 2016
@55 55 deleted the feature/disable-apikey-check branch July 28, 2016 08:11
@55 55 removed the in progress label Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@55 55

Labels
None yet
Projects
None yet
Milestone
Sprint 27
Development

Successfully merging this pull request may close these issues.

Ensure api managers can disable API key check on Backends
2 participants
@jykae @55