Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/single api page view #1347

Merged
merged 58 commits into from
Aug 3, 2016
Merged

Feature/single api page view #1347

merged 58 commits into from
Aug 3, 2016

Conversation

55
Copy link
Contributor

@55 55 commented Jul 27, 2016 •
edited by bajiat

Closes #1203

@55 55 added this to the Sprint 27 milestone Jul 27, 2016
@55 55 removed the WIP label Aug 2, 2016
frenchbread
frenchbread reviewed Aug 2, 2016
View reviewed changes
apis/client/view/header/header.less
}

.page-head-starsblock {
font-size: 16px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font-size in ems?

@frenchbread
Copy link
Contributor

frenchbread commented Aug 2, 2016 •
edited

This's quite big PR & covers more than just UI enhancements for API Backend view. Good job 👍

Still there are some minor fixes that are needed:

  1. When page's with API backend loaded initially, starring widget looks broken
    screen shot 2016-08-02 at 15 56 22
  2. In code, change font-size px to em where it's possible

@frenchbread
Copy link
Contributor

Looks good 🤘

@frenchbread frenchbread merged commit a0bd4ed into develop Aug 3, 2016
@frenchbread frenchbread deleted the feature/single-api-page-view branch August 3, 2016 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frenchbread frenchbread

Labels
None yet
Projects
None yet
Milestone
Sprint 27
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@55 @frenchbread