Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/api logo error #1367

Merged
merged 9 commits into from
Aug 9, 2016
Merged

Hotfix/api logo error #1367

merged 9 commits into from
Aug 9, 2016

Conversation

55
Copy link
Contributor

@55 55 commented Aug 8, 2016

Closes #1366

@apinf/developers, please review.
Test by uploading documentation and logo files.

@55 55 added this to the Sprint 28 milestone Aug 8, 2016
@55 55 added the in progress label Aug 8, 2016
@jykae
Copy link
Contributor

jykae commented Aug 9, 2016

@NNN Reviewing

@jykae
Copy link
Contributor

jykae commented Aug 9, 2016

Adding & Deleting of API logo & documentation seems to work fine.
However API logo is not visible in catalogue :(

nayttokuva 2016-08-09 kello 14 37 20

@jykae
Copy link
Contributor

jykae commented Aug 9, 2016

@NNN I am trying to look in the issue..

@55
Copy link
Contributor Author

55 commented Aug 9, 2016

@jykae, thanks, really appreciate it!

@jykae
Copy link
Contributor

jykae commented Aug 9, 2016

@NNN Used API backend from template instance data & used that for finding right API backend in template helper. Could you test it @NNN ? I think we can merge this then.

@55
Copy link
Contributor Author

55 commented Aug 9, 2016

@jykae, tested, thanks for the fix.

@jykae jykae merged commit c84ff71 into develop Aug 9, 2016
@jykae jykae deleted the hotfix/api-logo-error branch August 9, 2016 12:56
@jykae jykae removed the in progress label Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants