Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting for SDK download #1468

Merged
merged 3 commits into from
Sep 1, 2016
Merged

Add a setting for SDK download #1468

merged 3 commits into from
Sep 1, 2016

Conversation

marla-singer
Copy link
Contributor

@marla-singer marla-singer commented Aug 30, 2016

Closes #1433

  • Add fileds for setting Codegen instance in Setting platform: collection and view
  • Change condition for button 'SDK Generator': Button is available if there is a setting for SDK generator
  • Change host from generator.swagger.io to the Codegen instance defined in Settings.

@brylie
Copy link
Contributor

brylie commented Aug 31, 2016

Please be aware that @jykae is restructuring the Documentation module folder to follow our recently added folder structure guidelines.

The relevant part is as follows:

  • /module_name
    • /client
      • /component
        • sub_component.html
        • sub_component.js
        • /sub_component
          • sub_component.html
          • sub_component.js

This prevents sub-components from needing their own client folders, since they are under a shared client folder.

@marla-singer
Copy link
Contributor Author

Ok, I will pull changes by @jykae for Documentation module

}
},
documentationLink: function() {
documentationLink: function () {
Copy link
Contributor

@brylie brylie Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ES2015 enhanced object literal notation here:

documentationLink () {
  ...
},

@brylie
Copy link
Contributor

brylie commented Aug 31, 2016

This PR looks good. There are a couple of cleanup and consistency improvements, noted above.

@brylie
Copy link
Contributor

brylie commented Aug 31, 2016

Also, consider linting this PR with ESLint. We have an open PR for ESLint configuration #1466, which you can use as a basis.

@brylie
Copy link
Contributor

brylie commented Aug 31, 2016

@marla-singer please resolve conflicts. We merged a refactoring branch that touched some of the documentation module files.

@brylie
Copy link
Contributor

brylie commented Aug 31, 2016

Thanks. We are trying to organize our code for consistency lately, so things are moving around as we are working.

@brylie brylie added this to the Sprint 30 milestone Aug 31, 2016
@brylie brylie self-assigned this Aug 31, 2016
@brylie
Copy link
Contributor

brylie commented Aug 31, 2016

When I try to save the Codegen setting, the form does not appear to submit. I click the button, but nothing happens. No error is visible in the console.

@brylie
Copy link
Contributor

brylie commented Aug 31, 2016

There appears to be a regression in the develop branch.

@marla-singer
Copy link
Contributor Author

When I tested this feature on my old localhost version, it worked correct.
But now I did meteor reset and had this problem too. However another fields on this page don't work too.

@brylie
Copy link
Contributor

brylie commented Aug 31, 2016

It appears related to switching the Settings collection file to using export. I have a fix in progress.

@brylie
Copy link
Contributor

brylie commented Aug 31, 2016

See PR #1475

@brylie
Copy link
Contributor

brylie commented Aug 31, 2016

The fix may not be as simple as I originally thought. I will have to continue working on this tomorrow.

@brylie brylie removed the WIP label Sep 1, 2016
@brylie brylie merged commit 8eba61f into develop Sep 1, 2016
@brylie brylie deleted the feature/add-setting-for-sdk branch September 1, 2016 11:41
@brylie brylie removed the in progress label Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants