-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a setting for SDK download #1468
Conversation
Please be aware that @jykae is restructuring the Documentation module folder to follow our recently added folder structure guidelines. The relevant part is as follows:
This prevents sub-components from needing their own |
Ok, I will pull changes by @jykae for Documentation module |
} | ||
}, | ||
documentationLink: function() { | ||
documentationLink: function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use ES2015 enhanced object literal notation here:
documentationLink () {
...
},
This PR looks good. There are a couple of cleanup and consistency improvements, noted above. |
Also, consider linting this PR with ESLint. We have an open PR for ESLint configuration #1466, which you can use as a basis. |
@marla-singer please resolve conflicts. We merged a refactoring branch that touched some of the documentation module files. |
Thanks. We are trying to organize our code for consistency lately, so things are moving around as we are working. |
When I try to save the Codegen setting, the form does not appear to submit. I click the button, but nothing happens. No error is visible in the console. |
There appears to be a regression in the |
When I tested this feature on my old localhost version, it worked correct. |
It appears related to switching the Settings collection file to using export. I have a fix in progress. |
See PR #1475 |
The fix may not be as simple as I originally thought. I will have to continue working on this tomorrow. |
6171a76
to
ab14585
Compare
Closes #1433
generator.swagger.io
to the Codegen instance defined in Settings.