Refactor apiUmbrellaWeb usage #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,34 +24,25 @@ Meteor.methods({ | |||
| } | |||
| }, | |||
| 'createApiUmbrellaWeb': function () { | |||
| const settings = Settings.findOne(); | |||
| // Assume one proxy only | |||
There was a problem hiding this comment.
Add a TODO here mentioning that we need to refactor this method for multi-proxy support. That way we will remember what files to edit.
|
@jykae this looks good. Please add the TODO comment, and we can merge the PR. |
|
@brylie TODO added |
|
I added a commit to clarify the comment. I.e. a TODO should be a verb, something that we have to do. |
|
@brylie Ok, thanks. Anything else or could we merge this so I could use it in apiKey PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1485
Proposed changes
Please review @apinf/developers