-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/api-settings-export-fixes #1497
Conversation
# Conflicts: # apis/client/view/header/header.html # apis/client/view/view.html
There are still some issues with the i18n keys, so please observe how other i18n keys are structured. Also, make use of nesting to improve readability. Add a newline after HTML tags, so that child elements are indented one level. |
@brylie added suggested changes. |
<li> | ||
<a href="#api-export" data-toggle="tab"> | ||
<a href="#api-backend-export" data-toggle="tab"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small detail, but the word 'backend' was removed on purpose, please revert -- and if possible, remove Backend from the template name too.
Basically, the word 'backend' is appearing in our code quite a lot, and is not really helping improve readability. We have been removing 'backend' and 'frontend' from our user interface and code, to the extent possible.
I can remove the 'backend' from viewApiBackend
and all related i18n strings, if you will just clean up this part of the code.
This is really close. One thing I have been trying to do is remove 'backend' from our code and user interface. It was used in a confusing manner for both end users and developers. We are switching to the following terminology for simplicity:
We are only using 'backend' related to the third case, in order to distinguish it from a regular API, and to make it easier to describe our software. |
I can make the above change, but it is important that we all know to limit the word 'backend'. |
@brylie, got it, thanks for the explanation. |
@NNN I made the changes, renaming API related templates for consistency. |
@NNN please review. |
Closes #1385