Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/delete api backend #1517

Merged
merged 24 commits into from
Sep 8, 2016
Merged

Feature/delete api backend #1517

merged 24 commits into from
Sep 8, 2016

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Sep 8, 2016 •
edited by bajiat

Closes #1516
Closes #1508

Changes

  • restructure Feedback files into own module
  • clean up AutoForm hooks for Delete API

Known issues

  • submit feedback form causes page refresh

@brylie brylie added this to the Sprint 30 milestone Sep 8, 2016
@jykae
Copy link
Contributor

jykae commented Sep 8, 2016

Reviewing

@jykae
Copy link
Contributor

jykae commented Sep 8, 2016

@brylie Nice refactoring and delete also seems to function now.

@jykae jykae merged commit f94a6ad into develop Sep 8, 2016
@jykae jykae deleted the feature/delete-api-backend branch September 8, 2016 13:07
@jykae jykae removed the in progress label Sep 8, 2016
@brylie brylie mentioned this pull request Sep 9, 2016
Merged
@ilarimikkonen ilarimikkonen added this to In Review in apinf/platform Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jykae jykae

Labels
Ready for review
Projects
apinf/platform
In Review
Milestone
Sprint 30
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brylie @jykae