Feature/disable apikey #1518
Merged
Feature/disable apikey #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by #1520 |
|
Status update? Can you start by adding UI and only then store to UI? |
|
@bajiat, yes, the problem is that I couldn't submit Proxy form. Trying it again today. |
brylie
suggested changes
Sep 19, 2016
| 'disable_api_key': { | ||
| type: Boolean, | ||
| optional: true, | ||
| label: 'Disable API Key', |
There was a problem hiding this comment.
We need to internationalize this label.
|
Add internationalization. |
|
This is really close. Just switch identifiers to ID rather than class, when there is only one 'instance' or a particular element on a page. |
brylie
approved these changes
Sep 21, 2016
| @@ -120,9 +120,31 @@ | |||
| {{_ "proxyBackendForm_apiPort_helpText" }} | |||
| </p> | |||
| </div> | |||
|
|
|||
| <!-- Advanced settings --> | |||
| <div class="form-group col-md-12 advanced-settings"> | |||
There was a problem hiding this comment.
If this is the only 'advanced-settings' element on the page, use id instead of class.
| </div> | ||
|
|
||
| <!-- submit button --> | ||
| <button type="submit" class="btn btn-primary pull-right">Save proxy settings</button> | ||
| <button type="submit" class="btn btn-success pull-left save-proxy-button"> |
There was a problem hiding this comment.
If this is the only 'save-proxy-button' element on the page, use id rather than class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #622