Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix collection permissions #1522

Merged
merged 11 commits into from
Sep 9, 2016
Merged

Feature/fix collection permissions #1522

merged 11 commits into from
Sep 9, 2016

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Sep 9, 2016 •
edited

Closes #1413
Closes #1415
Closes #1425
Closes #1523

Changes

  • make sure userId and document parameters are passed in to all allow/deny rules
  • improve Settings collection security
  • improve FeedbackVotes collection security
  • improve Ratings collection security
  • refactor ApiBackendRatings collection to follow project structure guidelines

@brylie brylie added this to the Sprint 30 milestone Sep 9, 2016
@brylie
Copy link
Contributor Author

brylie commented Sep 9, 2016

@apinf/core please review ASAP.

@jykae jykae self-assigned this Sep 9, 2016
@jykae
Copy link
Contributor

jykae commented Sep 9, 2016

Reviewing

@jykae
Copy link
Contributor

jykae commented Sep 9, 2016

@brylie Autoform errors with Feedback form, also after "Submit", feedback not added. Can not merge this yet.

nayttokuva 2016-09-09 kello 12 52 43

@brylie
Copy link
Contributor Author

brylie commented Sep 9, 2016 •
edited

Those errors are not related to this PR. Please continue.

Feedback form error are a regression from a different PR.

@jykae jykae merged commit 4bde13a into develop Sep 9, 2016
@jykae jykae deleted the feature/fix-collection-permissions branch September 9, 2016 11:25
@jykae jykae removed the in progress label Sep 9, 2016
@ilarimikkonen ilarimikkonen added this to In Review in apinf/platform Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jykae jykae

Labels
Ready for review
Projects
apinf/platform
In Review
Milestone
Sprint 30
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brylie @jykae