-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove both lib server folders #1555
Feature/remove both lib server folders #1555
Conversation
…oard into feature/remove-both-lib-server-folders
@marla-singer thanks for the quick review. I have made small changes to 18 files, related to |
@@ -60,10 +60,10 @@ Template.apiBackendRating.events({ | |||
// Make sure there is a Meteor user ID for voting | |||
if (Meteor.userId() === null) { | |||
// Get translated user message | |||
const userMessage = TAPi18n.__('api-backend-rating-anonymous'); | |||
const message = TAPi18n.__('api-backend-rating-anonymous'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preferably use underscore instead of dash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been changed.
I am going to double-check our i18n hyphens. |
OK, I was looking at i18n strings and realized we are no longer using the |
Made the requested fixes. Please review. |
@marla-singer I have fixed the conflicts. Please review and merge, if possible, ASAP. |
Closes #936
Closes #1556
Closes #1557
Closes #1558
Closes #1559
Closes #1575
Closes #1577
Closes #1578
Closes #1579
Changes
/both
folder into relevant locations/lib
folder into relevant locations/server
folder into relevant locationseditApi
componentmanageApis
component