Email improvements #1561

jykae · 2016-09-12T12:30:16Z

Closes #1123
Closes #1514

Proposed changes

new fields SMTP Host & Port for Mail settings
contact form is enabled when mail is enabled & contact form email is given
send email verification after account creation (registration)
notify user about unverified email on frontpage, provide resend verification email link.

Other

move some files to more appropriate path based on our new guidelines

Testing

use SMTP host smtp.mailgun.org and SMTP port 587 for testing with Mailgun account
register new account with existing email address to test email verification

bajiat · 2016-09-13T08:15:31Z

@NNN @marla-singer @frenchbread One of you, please volunteer to review by assigning yourself

…l-improvements

marla-singer · 2016-09-15T11:24:38Z

@jykae When I started application at first time and created admin user, I have a message about e-mail verification although the SMTP settings didn't exist.

marla-singer · 2016-09-15T11:42:44Z

@jykae After creating new user, it redirects to home page and user is already logined. Also user, who doesn't verify e-mail, can go to Catalogue, add new api and do some manipulations with this api. But user don't have permission to add documentation or upload api logo. When he/she is clicking on button, nothing happens. It's just only console error, which can't be seen by typical users. And it looks very strange for them.
I think it's bad scenario. Either after sign up it redirects to home page without logging (that is logical and it is used everywhere) or it should has sAlert as "You don't have permissions for this.Please verify your e-mail"

jykae · 2016-09-15T11:52:09Z

This is what we talked today in daily. I wanted to get initial review how this looks like. In daily I asked about how the user flow should go, as I didn't have clear understanding how we want it to be.

And first user is one special case, that I did not even thought yet, we should allow first admin user to access platform and make settings. Thanks for review!

marla-singer · 2016-09-15T13:34:05Z

The ideas to improve an e-mail verification:

Add some time limit when link is worked. Maybe it shouldbe daily period or something. Notice to user why the link isn't worked.
If user requests a verification second time, the first link must be non-working. Notice to user that the link isn't worked and why.
If user clicks the link a second time, it should be displayed a message that the link is outdated or incorrect. Notice to user that the link isn't worked and why.
When user go to link from e-mail, show an intermediate page with message "Your e-mail is verifyed. It should beredirect to home page". Now it's just clear page

jykae · 2016-09-19T14:39:49Z

@brylie requested changes done, ready for review

…l-improvements

brylie · 2016-09-20T08:52:31Z

core/helper_functions/mail_helpers.js

+  const branding = Branding.findOne();
+
+  // Check branding exists
+  if( branding ) {


We need to check if (branding && branding.siteTitle), since site title is optional.

brylie · 2016-09-20T08:54:13Z

core/helper_functions/mail_helpers.js

+  // Check settings exists
+  if( settings && settings.mail && settings.mail.fromEmail ) {
+    // Return fromEmail
+    return '<'+settings.mail.fromEmail+'>';


Move these < and > out of this function. Follow the single responsible principle here. In effect this function should only get the email, not get the email and transform it.

Each variable, each line of code, each function, each class, each project should Do One Thing.

Curly's Law

brylie · 2016-09-20T09:01:34Z

settings/collection/schema.js

@@ -46,7 +46,7 @@ Settings.schema = new SimpleSchema({
      if (mailEnabled === true && !mailUsername) {
        return 'required';
      }
-    },
+    }


Make sure you are using ESLint while developing. We have an ESLint rule that requires trailing commas now, based on the Airbnb rules.

brylie · 2016-09-20T09:01:49Z

settings/collection/schema.js

@@ -60,7 +60,7 @@ Settings.schema = new SimpleSchema({
      if (mailEnabled === true && !mailPassword) {
        return 'required';
      }
-    },
+    }


Make sure you are using ESLint while developing. We have an ESLint rule that requires trailing commas now, based on the Airbnb rules.

jykae · 2016-09-20T10:22:57Z

@brylie requested trailing commas added automagically :)

jykae · 2016-09-20T11:08:15Z

@brylie Fixed conflict with eslint

jykae · 2016-09-21T09:25:07Z

@brylie Do you agree my lintings and latest fixes?

Move files

80dc6b6

jykae added this to the Sprint 31 milestone Sep 12, 2016

jykae added the in progress label Sep 12, 2016

Fixes to try out email with contact form

93bd97b

marla-singer self-assigned this Sep 13, 2016

Merge branch 'develop' of github.com:apinf/platform into feature/emai…

2a1ffd7

…l-improvements

This was referenced Sep 14, 2016

Add a setting for SMTP configuration #1514

Closed

Verify emails after sign up #1123

Closed

Ville Jyrkkä added 15 commits September 14, 2016 11:08

Mail field changes

0a76a67

Use smtpHost & port fields

a24aee5

Add new fields to form

d461530

Fix contactForm enabling logic

b8e967d

Make contact form email optional

fc38b9a

Notify about unverified email

cab7b94

Add email verification route

03a341e

Send email verification after registration

d7ef3fa

sendVerificationLink method

ec6a196

add email template

96edd0b

Fix conflicts from develop

6df134d

Fix conflicts from develop

29f9b42

Remove console log

bed029c

Check email settings are enabled

ac4768f

Don't show notification for unregistered user

221edb5

jykae added the Ready for review label Sep 15, 2016

marla-singer removed the Ready for review label Sep 15, 2016

Ville Jyrkkä added 9 commits September 19, 2016 14:55

do what function says

f3934d1

Add comment for urlWithoutHash

b711572

Make configurable, add i18n

184f989

Add fromEmail, add i18n to labels

37e764b

Add mail helpers

2fa6b8c

Add fromEmail field

65b601e

Use mail helpers, add i18n

4e6037d

Move form hints, add new for mail

eca1e16

Add i18n for form hints

9e72eeb

jykae added the Ready for review label Sep 19, 2016

Merge branch 'develop' of github.com:apinf/platform into feature/emai…

9ecfbf6

…l-improvements

bajiat assigned brylie Sep 20, 2016

brylie reviewed Sep 20, 2016

View reviewed changes

brylie suggested changes Sep 20, 2016

View reviewed changes

brylie removed the Ready for review label Sep 20, 2016

Automagically fix eslint trailing comma on save, whoa!

50cd465

jykae added the Ready for review label Sep 20, 2016

FIx conflict

8ee0ec3

Ville Jyrkkä added 3 commits September 20, 2016 14:18

ESLint: Import tap18n

870907c

Add double underscore dangle

60ccce4

Lintings & function fixes

59c529b

brylie approved these changes Sep 21, 2016

View reviewed changes

brylie merged commit e556b94 into develop Sep 21, 2016

brylie removed the in progress label Sep 21, 2016

brylie deleted the feature/email-improvements branch October 3, 2016 10:42

ilarimikkonen added this to In Review in apinf/platform Apr 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Email improvements #1561

Email improvements #1561

jykae commented Sep 12, 2016 •

edited by bajiat

bajiat commented Sep 13, 2016

marla-singer commented Sep 15, 2016

marla-singer commented Sep 15, 2016

jykae commented Sep 15, 2016 •

edited

marla-singer commented Sep 15, 2016 •

edited

jykae commented Sep 19, 2016

brylie Sep 20, 2016 •

edited

brylie Sep 20, 2016 •

edited

brylie Sep 20, 2016

brylie Sep 20, 2016

brylie Sep 20, 2016

jykae commented Sep 20, 2016

jykae commented Sep 20, 2016

jykae commented Sep 21, 2016

Email improvements #1561

Email improvements #1561

Conversation

jykae commented Sep 12, 2016 • edited by bajiat

Proposed changes

Other

Testing

bajiat commented Sep 13, 2016

marla-singer commented Sep 15, 2016

marla-singer commented Sep 15, 2016

jykae commented Sep 15, 2016 • edited

marla-singer commented Sep 15, 2016 • edited

jykae commented Sep 19, 2016

brylie Sep 20, 2016 • edited

Choose a reason for hiding this comment

brylie Sep 20, 2016 • edited

Choose a reason for hiding this comment

brylie Sep 20, 2016

Choose a reason for hiding this comment

brylie Sep 20, 2016

Choose a reason for hiding this comment

brylie Sep 20, 2016

Choose a reason for hiding this comment

jykae commented Sep 20, 2016

jykae commented Sep 20, 2016

jykae commented Sep 21, 2016

jykae commented Sep 12, 2016 •

edited by bajiat

jykae commented Sep 15, 2016 •

edited

marla-singer commented Sep 15, 2016 •

edited

brylie Sep 20, 2016 •

edited

brylie Sep 20, 2016 •

edited