Contact form

[frenchbread]

Closes #1572
Closes #884

[frenchbread]

Partly fixed, mail settings fetch refactored. Yet, the contact form data is not delivered via email..

[frenchbread]

Autoform is already used for the contact form.

[brylie]

@frenchbread note that this is related to the API Feedback form, rather than the Home page contact form.

The API Feedback form is not submitting correctly.

https://github.com/apinf/platform/tree/develop/feedback/client/form

[brylie]

This is dangerous code. Settings.findOne() may return undefined, or the .mail attribute may be undefined.

When you use mailSettings.toEmail on line 22, it may throw an error if either of the above cases were true.

[frenchbread]

note that this is related to the API Feedback form, rather than the Home page contact form.

@brylie Right, my bad. Closing this branch

[brylie]

@frenchbread it is OK, and the changes are actually helpful.

Please open an issue related to the 'contact form' and open a PR with this branch.

[brylie]

I updated the PR description with a new task related to this fix.

@frenchbread please verify whether issue #884 is also fixed by this PR. If so, add 'Closes #884' to the task description. After you have checked #884, add the 'ready for review' label to this PR.

[frenchbread]

@brylie Verified. Please review

[brylie]

@frenchbread I am merging this now.

Note that we need to add Closes # on a new line for each issue that a PR closes in order for the issue to be properly linked. You can use alternative keywords like 'fixes', etc., but they have to be on a new line for each linked issue.