Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/enable GitHub settings #1593

Merged
merged 3 commits into from
Sep 16, 2016
Merged

Bugfix/enable GitHub settings #1593

merged 3 commits into from
Sep 16, 2016

Conversation

jykae
Copy link
Contributor

@jykae jykae commented Sep 15, 2016 •
edited

Closes #1591

Proposed changes

  • make Github settings function Meteor method
  • call method on settings form onSuccess hook to update Github settings

@jykae jykae added this to the Sprint 31 milestone Sep 15, 2016
@jykae
Copy link
Contributor Author

jykae commented Sep 15, 2016

@apinf/developers please review, fixes regression

One small cave-eat, that has been probably earlier also.
If Github setting fields are saved blank, ServiceConfiguration does not get removed. But that could be enhancement if we make it possible to enable/disable also this Github login.

@brylie brylie self-assigned this Sep 16, 2016
@brylie brylie merged commit d489b47 into develop Sep 16, 2016
@brylie brylie deleted the bugfix/enable-github-settings branch September 16, 2016 03:32
@ilarimikkonen ilarimikkonen added this to In Review in apinf/platform Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brylie brylie

Labels
Ready for review
Projects
apinf/platform
In Review
Milestone
Sprint 31
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jykae @brylie