Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/update-api-apiumbrella #1601

Merged
merged 18 commits into from
Sep 27, 2016
Merged

feature/update-api-apiumbrella #1601

merged 18 commits into from
Sep 27, 2016

Conversation

55
Copy link
Contributor

@55 55 commented Sep 16, 2016

Closes #1510

@55 55 added the in progress label Sep 16, 2016
@55 55 added this to the Sprint 31 milestone Sep 16, 2016
@marla-singer
Copy link
Contributor

@NNN Is it ready for review? Please use the label 'Ready for review' to make it clear when a PR is ready.

@marla-singer marla-singer self-assigned this Sep 22, 2016
@frenchbread frenchbread self-assigned this Sep 26, 2016
@frenchbread
Copy link
Contributor

Code looks good! Was not able to verify while testing though. Updated API on local Apinf and it was not updated on API Umbrella. @brylie have you been able to test?

@brylie
Copy link
Contributor

brylie commented Sep 27, 2016

@frenchbread yes, I was able to test and demonstrated for @bajiat. Try doing a meteor reset perhaps? Did you see any console errors?

@frenchbread
Copy link
Contributor

@brylie There are no any console errors.

Form cannot finish submit ("Publish" button is disabled & nothing happens). Sometimes form finishes submit & throws a success message, but still, updates are not reflected on API Umbrella.

@frenchbread
Copy link
Contributor

@jykae Could you please test it & verify that is works? Then we could merge this sooner.

@jykae
Copy link
Contributor

jykae commented Sep 27, 2016

@frenchbread I could check this today afternoon

@jykae
Copy link
Contributor

jykae commented Sep 27, 2016

Reviewing

@jykae
Copy link
Contributor

jykae commented Sep 27, 2016

Insert & update both work, tested with "nightly.apinf.io" Umbrella.

@jykae jykae merged commit 24a1f16 into develop Sep 27, 2016
@jykae jykae removed the in progress label Sep 27, 2016
@jykae jykae deleted the feature/update-api-apiumbrella branch September 27, 2016 14:39
@ilarimikkonen ilarimikkonen added this to In Review in apinf/platform Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants