Delete proxy backend

[jykae]

Closes #1509

Proposed changes

• delete proxyBackend feature
• improve code style where appropriate with my new friend ESLint

[brylie]

The following submit/delete button group code works properly, where clicking delete does not trigger the update event:

<div id="proxy-form-buttons" class="btn-group pull-left">
  <!-- submit button -->
  <button
    type="submit"
    class="btn btn-success"
    id="save-proxy-button">
    {{_ "proxyBackendForm_saveButton" }}
  </button>
  <!-- delete button -->
  <button
    type="button"
    class="btn btn-danger"
    id="delete-proxy-button">
    Delete
  </button>
</div>

[brylie]

You will also need to change your form.less:

/* Change the following */
#save-proxy-button {
  #margin-top: 1em;
}

/* to */
#proxy-form-buttons {
  #argin-top: 1em;
}

[jykae]

@brylie Ok, thanks. I try out. Just pushed functionality.

[jykae]

@brylie Seems to work. I push also UI changes.

[jykae]

@apinf/developers ready for review

[brylie]

This looks good. Try to reduce the amount of nesting involved in the delete event handler. That will make the code slightly easier to read.

[brylie]

Unless there is a syntactic reason to separate these statements, combine them into one if statement. Separate each conditional on its own line:

if (proxyBackend &&
 proxyBackend.apiUmbrella &&
 proxyBackend.apiUmbrella.id ) {
  // do something
}

[brylie]

Nice use of template strings 😄