Fix console errors after deleting api #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NNN Could you please review it? |
|
@marla-singer on it. |
55
reviewed
Sep 21, 2016
| "deleteApiBackendConfirmation_deleteButton": "Delete", | ||
| "deleteApiBackendConfirmation_header": "Delete API", | ||
| "deleteApiBackendConfirmation_successMessage": "Successfully deleted API:", | ||
| "deleteApiConfirmation_CancelButton": "Cancel", |
| <button type="button" class="btn btn-default" data-dismiss="modal">{{_ "deleteApiBackendConfirmation_CancelButton"}}</button> | ||
| <button type="button" class="btn btn-danger" id="deleteApi">{{_ "deleteApiBackendConfirmation_deleteButton"}}</button> | ||
| <button type="button" class="btn btn-default" data-dismiss="modal"> | ||
| {{_ "deleteApiConfirmation_CancelButton"}} |
|
@NNN Done |
|
Also if there is an error or something prevents it from deleting, what will happen? |
|
Before It was just console out with error message what isnot good too. I think we should create another issue which will be solve this scenario |
|
@marla-singer I am just not sure that it's the right way to clean those error. @brylie what do you think? |
|
@NNN I think this is close enough for now. I see the original problem was with calling Lets merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1519