Feature/fix i18n token usage

[brylie]

Closes #1681

Changes

• Remove unnecessary spaces from before _ in template helpers
• import TAPi18n

[brylie]

@frenchbread please review.

Ping @bajiat

[frenchbread]

@brylie Shouldn't we move towards common approach we are taking with templates (or template variables) like:

{ > templateName }

And have the same pattern with i18n strings?

{ _ 'template_headerText' } 

[brylie]

A quick search of our code found the following counts:

• 139 results for {{>
• 22 results for {{ >

Similarly, we tend to keep the # character next to the {{ in template block helpers:

• 107 results for {{#
• 41 results for {{ #

I think we should prefer the first version, keeping > and # close to the {{ for these reasons:

• both cases are more common in our code, currently
• the > and # characters are a bit noisy, since they are not English words (i.e. they are more to help the computer than the developer who is reading the sourcecode)
• combining the {{> and {{# into single string, without space, makes them simpler (both to read and type)

[frenchbread]

both cases are more common in our code, currently

Before using eslint for js we did not care about spacing in the code. After we started using it we refactored all the code to fit it, and to have spaces.

combining the {{> and {{# into single symbols becomes a semantic unit

Disagreed here, since {{ }} are used to tell parser to operate differently than to HTML. >, # and _ are kind of operators here for specific cases.

I think it's better to keep {{ > someThing }} "with spaces" approach here, since it is:

• Consistent
• Easy to read

In terms of rewriting all the code to the selected approach, is just a matter of opening search bar in atom with Cmd+Shift+F and replacing one peace of the code to another for the entire project.

[brylie]

{{ }} are used to tell parser to operate differently than to HTML. >, # and _ are kind of operators here for specific cases.

Right, both are used primarily to help the computer (parser) to do its job.

Combining them makes it easier for the human to read, and still accomplishes the same. I.e. {{_, {{> and {{# are easy for us to read and distinguish (without spaces), while the parser can still do its job just fine.

[brylie]

@frenchbread I realize our opinions are different, and there is no right or wrong here.

I would like to fix the other handlebars helpers, for consistency.

In a nutshell, I am proposing we remove the space infix because:

• handlebars spaces are unnecessary
• handlebars spaces do not significantly increase readability (although spaces increase readability elsewhere in our code)
  • i.e. template helpers without spaces between the prefix are easy to read, since the last character is easy to distinguish
• most template helpers in our code do not separate the handlebars ({{) from the prefix (_, >, #)

[brylie]

If it would help, we could do a quick vote/poll regarding this issue. Otherwise, I can just do the search/replace as part of this PR.

Ping @bajiat