Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/email verification #1766

Merged
merged 3 commits into from
Oct 12, 2016
Merged

Hotfix/email verification #1766

merged 3 commits into from
Oct 12, 2016

Conversation

marla-singer
Copy link
Contributor

@marla-singer marla-singer commented Oct 12, 2016

Closes #1728 (not releated)

Changes

  • Update users collections when updateMailConfiguration is called
  • Lint updateMailConfiguration methods

@marla-singer
Copy link
Contributor Author

@apinf/developers Please review

@brylie
Copy link
Contributor

brylie commented Oct 12, 2016

Excellent!

@brylie brylie added this to the Sprint 33 milestone Oct 12, 2016
@brylie brylie self-assigned this Oct 12, 2016
@brylie brylie merged commit a3bb6ee into develop Oct 12, 2016
@brylie brylie deleted the hotfix/email-verification branch October 12, 2016 09:43
@@ -56,6 +57,12 @@ Meteor.methods({
${encodeURIComponent(smtpPort)}
`;

// Update admin account. Set 'verified: true' for all admin user
Copy link
Contributor

@jykae jykae Oct 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marla-singer I think better place for this could

// Find user email & callback check if it's verified

You could do also that like

Roles.userIsInRole(userId, ['admin']);

Just check if user is admin and pass in without changing verified value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants