Feedback permissions #1804
Feedback permissions #1804
Conversation
| }, | ||
| }); | ||
|
|
||
| Template.singleFeedback.events({ | ||
| 'click .up-vote': function (event, template) { | ||
| 'click .up-vote': () => { |
There was a problem hiding this comment.
I observed You corrected code which is associated with vote system. I went ahead and merged yours two branch for feedback fixing. Arrow function broken all vote system. Please come back to previous code version.
There was a problem hiding this comment.
@marla-singer can you provide more info or screenshot, how does it break? voting was broken and part of other PR.
There was a problem hiding this comment.
@jykae Meteor console error Exception while invoking method 'submitVote' Error: Feedback id is required.
How to reproduce:
git checkout bugfix/feedback-voting- Repeat these changes for
feedback/client/single/single.js - Go to any api, open Feedback tab and try to vote
Possible solution: doesn't use an arrow function
There was a problem hiding this comment.
@marla-singer ah, it's because arrow function does not work same way with "this", line 80. https://rainsoft.io/when-not-to-use-arrow-functions-in-javascript/
| @@ -61,7 +85,7 @@ Template.singleFeedback.events({ | |||
| // Submit upvote (+1) for current feedback | |||
| Meteor.call('submitVote', feedbackId, 1); | |||
| }, | |||
| 'click .down-vote': function (event, template) { | |||
| 'click .down-vote': () => { | |||
There was a problem hiding this comment.
Please come back to previous code version.
|
@marla-singer changed arrow functions back to previous. |
|
@jykae Merge it |
Closes #1744
Closes #1170