-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require essential proxybackend fields #1806
Require essential proxybackend fields #1806
Conversation
@jykae Notification worked before too. I detected another problem and required fields don't resolve it.
Found result: Submit hook isn't end, button is disable, no one notification about required fields Should I create another issue or you will fix in this repo? |
@marla-singer good find, I'll check after lunch 🍽 |
@marla-singer There is open issue on autoform about this Meteor-Community-Packages/meteor-autoform#1442 I try to call that validateForm if it makes any difference, as @abecks suggests so. EDIT: no difference, returns also true for me. Trying to think something.. |
@jykae I had the same situation when worked on monitoring feature. I did the handle check on insert/update hook |
@marla-singer Well, it's not beauty but I think it checks now all "required" fields have values. Maybe I should add star for required field labels in addition to showing error message. EDIT: seems like there's separate issue for that #1171 |
@marla-singer could you check if this fixes now issue with empty fields? I would like to leave the star issue as enhancement, I don't know that much of CSS magic. |
@jykae Works 👍 I couldn't merge it because of console log in code so I afforded to delete it |
@marla-singer 🆒 and thanks for contribution 🎉 |
Closes #1562
Closes #1816