Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require essential proxybackend fields #1806

Merged
merged 7 commits into from
Oct 25, 2016

Conversation

jykae
Copy link
Contributor

@jykae jykae commented Oct 24, 2016

Closes #1562
Closes #1816

  • require essential proxybackend fields, regex validation kicks in only when field has some input

@marla-singer
Copy link
Contributor

@jykae Notification worked before too. I detected another problem and required fields don't resolve it.
Steps:

  1. Go to any API and open Proxy tab
  2. Click on Delete button, if there are any information
  3. Don't fill a form and click on Save&Publish button

Found result: Submit hook isn't end, button is disable, no one notification about required fields
Expected result: Notify users about required fields and button must be available

Should I create another issue or you will fix in this repo?

@marla-singer marla-singer self-assigned this Oct 25, 2016
@jykae
Copy link
Contributor Author

jykae commented Oct 25, 2016

@marla-singer good find, I'll check after lunch 🍽

@jykae
Copy link
Contributor Author

jykae commented Oct 25, 2016

@marla-singer There is open issue on autoform about this Meteor-Community-Packages/meteor-autoform#1442 I try to call that validateForm if it makes any difference, as @abecks suggests so.

EDIT: no difference, returns also true for me. Trying to think something..

@marla-singer
Copy link
Contributor

@jykae I had the same situation when worked on monitoring feature. I did the handle check on insert/update hook
https://github.com/apinf/platform/blob/develop/monitoring/client/autoform.js#L16

@jykae
Copy link
Contributor Author

jykae commented Oct 25, 2016

@marla-singer Well, it's not beauty but I think it checks now all "required" fields have values. Maybe I should add star for required field labels in addition to showing error message.

EDIT: seems like there's separate issue for that #1171

@jykae
Copy link
Contributor Author

jykae commented Oct 25, 2016

@marla-singer could you check if this fixes now issue with empty fields? I would like to leave the star issue as enhancement, I don't know that much of CSS magic.

@marla-singer
Copy link
Contributor

@jykae Works 👍 I couldn't merge it because of console log in code so I afforded to delete it

@marla-singer marla-singer merged commit 9c34319 into develop Oct 25, 2016
@marla-singer marla-singer deleted the bugfix/require-essential-proxybackend-fields branch October 25, 2016 15:31
@jykae
Copy link
Contributor Author

jykae commented Oct 26, 2016

@marla-singer 🆒 and thanks for contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants