Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only one primary rate limit for response headers #1809

Merged
merged 4 commits into from
Oct 25, 2016

Conversation

jykae
Copy link
Contributor

@jykae jykae commented Oct 24, 2016

Closes #1684

  • onChange event handler to allow only one primary rate limit for response headers

@jykae jykae added this to the Sprint 34 milestone Oct 24, 2016
'change input:checkbox[name*="response_headers"]': (event) => {
const changedCheckbox = $(event.target);

const checkboxesArray = $("input:checkbox[name*='response_headers']");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment for this line to describe an operation

@marla-singer
Copy link
Contributor

@jykae Works good. It's almost ready to merge

@jykae
Copy link
Contributor Author

jykae commented Oct 25, 2016

@marla-singer comment added

@marla-singer
Copy link
Contributor

@jykae Merge it

@marla-singer marla-singer merged commit 1246b81 into develop Oct 25, 2016
@marla-singer marla-singer deleted the feature/primary-ratelimit-enhancement branch October 25, 2016 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants