Feature/api 404 redirect #1837
Feature/api 404 redirect #1837
Conversation
|
@brylie Self assigned |
|
@brylie |
|
@brylie Sorry, looks like I have problem on my side |
| } | ||
| } | ||
|
|
||
| return apiExists; |
There was a problem hiding this comment.
I think it can be easy:
if (api) {
return true
} else {
return false
}And placeholder doesn't need
There was a problem hiding this comment.
I structured the code as such to make the linter happy. It was complaining that I had an unnecessary 'else' after a return:
| @@ -19,4 +19,40 @@ Meteor.methods({ | |||
| Apis.update(apiId, { $push: { authorizedUserIds: user._id } }); | |||
| } | |||
| }, | |||
| currentUserCanViewApi (apiId) { | |||
| // Placeholder for 'user is authorized' | |||
| let userAuthorized; | |||
There was a problem hiding this comment.
You can also simplify this one:
// Get API
const api = Apis.findOne(apiId);
// Check if user can view
return api && api.currentUserCanView()| }, | ||
| currentUserCanEditApi (apiId) { | ||
| // Placeholder for 'user can edit' | ||
| let userCanEdit; |
There was a problem hiding this comment.
And this one
// Get API
const api = Apis.findOne(apiId);
// Check if user can view
return api && api.currentUserCanEdit()
|
Ping @marla-singer. Changes made. |
| // Check if API exists | ||
| Meteor.call('checkIfApiExists', apiId, function (error, apiExists) { | ||
| // Check if API exists | ||
| if (apiExists === false) { |
There was a problem hiding this comment.
Edit this condition to
apiExists === undefined
|
@marla-singer I inverted the conditional, to make it easier to read and avoid the |
|
@brylie Nice solution 👍 Works as expected. Merge it |
Closes #1261
Changes