Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/email verification fix #1839

Merged
merged 5 commits into from
Oct 31, 2016
Merged

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Oct 28, 2016

Closes #1836

Changes

  • fix login validation method
  • always run login validation method
  • update validateSmtpSettings method
  • cleanup

@brylie brylie added this to the Sprint 34 milestone Oct 28, 2016
@marla-singer marla-singer self-assigned this Oct 31, 2016
@marla-singer
Copy link
Contributor

@brylie These is resovled issue. But I have the next information in meteor console:

====== BEGIN MAIL #0 ======

(Mail not sent; to enable sending, set the MAIL_URL environment variable.)

@brylie
Copy link
Contributor Author

brylie commented Oct 31, 2016

Right, the mail settings have to be configured in order for the MAIL_URL environmental variable to be set.

@brylie
Copy link
Contributor Author

brylie commented Oct 31, 2016

We have enabled verification emails at all times, which means that Meteor will sometimes try to send emails when the MAIL_URL environmental variable is not set. This is intentional, for now. We have a follow up task #1843

@marla-singer
Copy link
Contributor

marla-singer commented Oct 31, 2016

This is intentional, for now.

So, should I merge it? When MAIL_ENV is not set, email doesn't send to user.

@brylie
Copy link
Contributor Author

brylie commented Oct 31, 2016

Jep. That is expected. We have to figure out how to dynamically enable the email related features, but in the meantime opted to enable them by default.

@marla-singer
Copy link
Contributor

@brylie I'm goint to merge it with a view to MAIL_ENV will be set and will work correct in the PR for 1843 issue

@marla-singer marla-singer merged commit a302bff into develop Oct 31, 2016
@marla-singer marla-singer deleted the feature/email-verification-fix branch October 31, 2016 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign up allows user to login without completing email verification
2 participants