Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/contact form smtp #1847

Merged
merged 5 commits into from
Nov 1, 2016
Merged

Feature/contact form smtp #1847

merged 5 commits into from
Nov 1, 2016

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Oct 31, 2016

Closes #1842

Changes

  • use mail settings fromEmail when sending mail
  • refactor sendContactFormEmail method
    • lint
    • imports
    • template strings
    • explicit method name
  • use exports default for contact form schema

@brylie brylie added this to the Sprint 34 milestone Oct 31, 2016
@jykae jykae self-assigned this Nov 1, 2016
@jykae
Copy link
Contributor

jykae commented Nov 1, 2016

Reviewing

@jykae
Copy link
Contributor

jykae commented Nov 1, 2016

@brylie works nicely

@jykae jykae merged commit 4c9ae99 into develop Nov 1, 2016
@brylie brylie deleted the feature/contact-form-SMTP branch November 11, 2016 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jykae jykae

Labels
None yet
Projects
None yet
Milestone
Sprint 34
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brylie @jykae