Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cases for local & github registration #1859

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

jykae
Copy link
Contributor

@jykae jykae commented Nov 2, 2016

Closes #1856

  • add blocks for local & github registration, no need to send verification email on Github registration

@marla-singer
Copy link
Contributor

marla-singer commented Nov 3, 2016

@jykae Case 1 doesn't work as expected.
Steps

  1. Create user with name testapinf123
  2. Log out
  3. Sign up via GitHub using credentials:
    • testapinf123
    • q1w2e3r4

Found result:

  • redirect to profile page
  • 404 error
    joxi_screenshot_1478161060047

@marla-singer
Copy link
Contributor

marla-singer commented Nov 3, 2016

As recomendation it should show some popup after redirect with a message "Enter your username" or something like this. These isn't obviously why it redirects to profile, why my user name doesn't appear in right up corner?
User can be confused
joxi_screenshot_1478161475897

Well, you know, it can be like popup "Reset password"

@jykae
Copy link
Contributor Author

jykae commented Nov 3, 2016

@marla-singer Github sign up issue fixed in PR #1865 as continuance for this.

Redirect to profile page & sAlert is shown there right.

@marla-singer
Copy link
Contributor

@jykae I'm testing this case on another PR

@jykae
Copy link
Contributor Author

jykae commented Nov 3, 2016

3. Sign up via GitHub using credentials: 
 - testapinf123 
 - q1w2e3r4

Those are not probably your Github account credentials, so this is testing what happens when Github registration/login fails? I check out the case. thanks for testing, @marla-singer

PR #1865 only fixes github username taken redirect, that got broken during development, at some point.

@marla-singer
Copy link
Contributor

@jykae Nope. Ilia created this credentials special for test (when he fixed registration test)

@jykae
Copy link
Contributor Author

jykae commented Nov 3, 2016

Ah, so this user exists, https://github.com/testapinf123 :D sadly has not contributed a lot :/

@marla-singer
Copy link
Contributor

@jykae He has the world before one ;)

@jykae
Copy link
Contributor Author

jykae commented Nov 3, 2016

@marla-singer I think you had username "testapinf123" already in use for what you found. I get logged in nicely with "testapinf123". Does this need any further steps or can be merged?

@marla-singer
Copy link
Contributor

@jykae I think this branch we can merge. Issue with username is being resolved on another branch.

@marla-singer marla-singer merged commit c3f1c44 into develop Nov 3, 2016
@marla-singer marla-singer deleted the bugfix/no-need-verify-github-users-email branch November 3, 2016 14:15
@jykae jykae added this to the Sprint 34 milestone Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants