-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cases for local & github registration #1859
Conversation
@jykae Case 1 doesn't work as expected.
Found result: |
@marla-singer Github sign up issue fixed in PR #1865 as continuance for this. Redirect to profile page & sAlert is shown there right. |
@jykae I'm testing this case on another PR |
Those are not probably your Github account credentials, so this is testing what happens when Github registration/login fails? I check out the case. thanks for testing, @marla-singer PR #1865 only fixes github username taken redirect, that got broken during development, at some point. |
@jykae Nope. Ilia created this credentials special for test (when he fixed registration test) |
Ah, so this user exists, https://github.com/testapinf123 :D sadly has not contributed a lot :/ |
@jykae He has the world before one ;) |
@marla-singer I think you had username "testapinf123" already in use for what you found. I get logged in nicely with "testapinf123". Does this need any further steps or can be merged? |
@jykae I think this branch we can merge. Issue with username is being resolved on another branch. |
Closes #1856