-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multiproxy api keys #1896
Conversation
please review for functionality, if it works as suspected, I add i18n strings for errors etc. small things. Creating another issue/PR for updating "api_umbrella.js" functions for multiproxy support (ie. use proxyId) Should be merged as closely together to keep existing things function, imho. |
@jykae please resolve conflicts. |
@brylie yep, thx for merging groundwork that fast! |
@brylie conflicts solved |
I add i18n etc. & clean unnecessary console.logs. |
OK, let me know when it is ready. |
@brylie ready |
"apinf_usernotloggedin_error": "Could not find signed-in user.", | ||
"apinf_apiumbrellauser_error": "Error: Could not create user on proxy", | ||
"apinf_noproxy_error": "Error: No proxy found", | ||
"apinf_noproxybackend_error": "Error: No proxyBackend found", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be something like "No proxy backend found."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing it tomorrow :)
@brylie Will you review this? I.e. should the PR be assigned to you? |
@brylie Fixed. Anything else? |
Closes #1874