Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Horizontal scrollbar from APINF landing page #1934

Merged
merged 1 commit into from
Nov 18, 2016

Conversation

Uzmani
Copy link
Contributor

@Uzmani Uzmani commented Nov 18, 2016

Cause of horizontal scroll are the images in the "getting started" and "completely open source" sections. The bootstrap class 'col-lg-push-1' is pushing the that div outside of the .container width.

Removed the 'col-lg-push-1' from the html and added float:right to the images.

Closes #1867

@Uzmani
Copy link
Contributor Author

Uzmani commented Nov 18, 2016

@NNN,
This is ready for review/merge.

@Uzmani Uzmani changed the title Remove Horizontal scrollbar from APINF landing page #1867 Remove Horizontal scrollbar from APINF landing page Nov 18, 2016
@55 55 self-assigned this Nov 18, 2016
@55 55 merged commit 636d03f into apinf:develop Nov 18, 2016
@bajiat
Copy link
Contributor

bajiat commented Nov 18, 2016

@Uzmani Thanks for your contribution! Do you have Twitter account so that we could mention you in Twitter?

@Uzmani
Copy link
Contributor Author

Uzmani commented Nov 18, 2016

@bajiat No problem. My twitter handle is @Usmanistan.

Full disclosure: This is my first open source contribution EVER! Hopefully, I can help apinf more in the future :)

@Uzmani Uzmani deleted the bugfix/horizontal-scroll-remove branch November 19, 2016 20:35
@bajiat
Copy link
Contributor

bajiat commented Nov 21, 2016

Cool! So nice that you wanted to get started with open source and started from APInf! How did you find us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants