Remove URL parameter instruction #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reviewer
|
| @@ -59,14 +59,10 @@ <h3 id="api-url-title"> | |||
| {{# if hasApiKey }} | |||
| <!-- Proxy Backend is completed, "Disable api key" is false, user has got an api key --> | |||
| <li> | |||
| {{_ "apiDetails_usageInstructions_urlParameters_text" }} | |||
There was a problem hiding this comment.
Don't forget to delete an useless i18n tag
@jykae What do you mean? Can you please tell how can I check out these? |
|
@marla-singer that one was note to check idea, if we would really like to restrict API key usage to header only but I left it enhancement because the original task was just to instruct safer way. I could add separate enhancement issue of that, if we decide to go that way. |
|
@marla-singer removed texts |
|
@jykae Merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1349