Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topbar search field fix #2077

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Topbar search field fix #2077

merged 1 commit into from
Feb 7, 2017

Conversation

55
Copy link
Contributor

@55 55 commented Feb 7, 2017

Closes #2015

@55 55 added the in progress label Feb 7, 2017
@55 55 changed the title Change to meteor event; Comments Topbar search field fix Feb 7, 2017
@55 55 added this to the Sprint 36 milestone Feb 7, 2017
@marla-singer marla-singer self-assigned this Feb 7, 2017
@marla-singer
Copy link
Contributor

@NNN What does it resolve? The
joxi_screenshot_1486470068869 icon doesn't appear after searching

@marla-singer
Copy link
Contributor

joxi_screenshot_1486470120899

@marla-singer
Copy link
Contributor

Although as for me the Search page doesn't need this icon

@55
Copy link
Contributor Author

55 commented Feb 7, 2017

It designed this way. We should have only one search field on a page.
When user is on the search results page, an icon in the search field is hidden.

Fix is for search field doesn't appear if you go anywhere from search result page and try to click a search icon (see Nazia's GIF attached).

@marla-singer
Copy link
Contributor

@NNN Okay, I see the problem

@marla-singer marla-singer merged commit 3747e5e into develop Feb 7, 2017
@marla-singer marla-singer deleted the bugfix/search-field branch February 7, 2017 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marla-singer marla-singer

Labels
None yet
Projects
None yet
Milestone
Sprint 36
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@55 @marla-singer