Dashboard: the browser history #2088

marla-singer · 2017-02-08T10:37:02Z

Closes #2044

Solution

Using FlowRouter.withReplaceState() to modify the current history entry instead of creating a new one. Link to Doc
Initialize the query parameter in triggersEnter function to saving URL consistent. Because all query parameters excluding granularity are calculated in code.
1. The next URL are the same for the browser history:
- nightly.apinf.io/dashboard?backend=jwufbT5kXeDcP7mdP&granularity=month
- nightly.apinf.io/dashboard?backend=jwufbT5kXeDcP7mdP&granularity=week
1. The next URL are the different for the browser history
- nightly.apinf.io/dashboard?backend=jwufbT5kXeDcP7mdP&granularity=month
- nightly.apinf.io/dashboard?backend=MtejerXbEP92L5CJr&granularity=month

marla-singer · 2017-02-08T10:47:07Z

@apinf/developers Ready for review

marla-singer added 6 commits February 8, 2017 13:23

Update select menu when query params change

137bad7

Change attribute

1cd0301

Remove setting query params to router triggers

7b58455

make sure api id exists

280b97c

Initializa the query parameter in route triggers

3698432

Modifies the current history entry instead of creating a new one

f975c67

marla-singer added the in progress label Feb 8, 2017

marla-singer changed the title ~~Bugfix/dashboard back arrow~~ Dashboard: the browser history Feb 8, 2017

marla-singer added the Ready for review label Feb 8, 2017

marla-singer added this to the Sprint 36 milestone Feb 8, 2017

brylie self-assigned this Feb 8, 2017

brylie merged commit 82d52a2 into develop Feb 8, 2017

brylie deleted the bugfix/dashboard-back-arrow branch February 8, 2017 12:22

brylie removed in progress Ready for review labels Feb 8, 2017