Lint proxies directory #2103
Merged
Lint proxies directory #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove conditional
38 tasks
|
@apinf/developers please review |
|
|
||
| Meteor.publish('allProxies', function () { | ||
| let proxies; |
There was a problem hiding this comment.
For publish function the default value must be []
| @@ -70,6 +81,12 @@ Meteor.methods({ | |||
| } | |||
| }, | |||
| createApiBackendOnApiUmbrella (apiBackend, proxyId) { | |||
| // Make sure apiBackend is a String | |||
| check(apiBackend, String); | |||
There was a problem hiding this comment.
apiBackend is not a String. I'll check the type and write it
There was a problem hiding this comment.
Yes, it is. @mauriciovieira Change Strign type to Object
| @@ -70,6 +81,12 @@ Meteor.methods({ | |||
| } | |||
| }, | |||
| createApiBackendOnApiUmbrella (apiBackend, proxyId) { | |||
| // Make sure apiBackend is a String | |||
| check(apiBackend, String); | |||
There was a problem hiding this comment.
Yes, it is. @mauriciovieira Change Strign type to Object
| @@ -97,6 +114,12 @@ Meteor.methods({ | |||
| return response; | |||
| }, | |||
| updateApiBackendOnApiUmbrella (apiBackend, proxyId) { | |||
| // Make sure apiBackend is a String | |||
| check(apiBackend, String); | |||
There was a problem hiding this comment.
@mauriciovieira Change String type to Object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #2045 endeavor.