Org filter via label less helpers

[brylie]

• Remove unneeded helper
• add conditional checks for apisCount
• Decouple API count and 'Filtered by' text.
• Pluralize i18n strings
• cleanup
• consistency between Organization Profile and APIs Catalog

Organization Profile

APIs Catalog

APIs Catalog alternative

[marla-singer]

@brylie Wait feedback from @Nazarah and @bajiat about replace counter

[brylie]

We can still work with the text positioning and wording.

I am simply showing that the suggestions will work, since the conversation had become a bit of a struggle. The main point here is to demonstrate the requested changes, suggesting a cleaner way to organize this feature while preserving the user experience. E.g.

[marla-singer]

@brylie I don't mind about your suggestion. It allows saving a simple way. But is it okay that we change the design idea?

[brylie]

@marla-singer a wireframe/mockup is generally a guide to get started.

When we start implementing the feature, things will naturally change slightly. It is not always possible, or desirable, to implement code exactly as initially sketched - although we try to stick as close to the original intention.

[marla-singer]

@brylie Just recommendation, no obligation?

[brylie]

It is not a strict oblication. We try, as developers, to honor the spirit of the design (the intention). However, we sometimes deviate from the design when we encounter limitations or constraints the design did not conceive.

[marla-singer]

Your suggestion is good, anyway. One feature must do one thing. Either show count or filter criterion

[brylie]

Cool. I have posted two alternatives for the API Catalog changes (in the PR description). Which do you like better?

[marla-singer]

Don't forget to delete useless i18n tags

[brylie]

I can't find that tag in the en.i18n.js file.

[marla-singer]

https://github.com/apinf/platform/blob/develop/core/lib/i18n/en.i18n.json#L91-L94

[marla-singer]

The second one. But don't place it in <small> tag, just like in Organization profile

[brylie]

Here is what happens when I pull the text outside of the <small></small> tags:

[55]

In my opinion, this approach is better.

[brylie]

Cool, @Nazarah also just reviewed it and will post her preference.

[marla-singer]

@NNN Sure?

[Nazarah]

In catalog view, the number of APIs can appear beside the "APIs" headline.
But "filtered by" text and clear all should come below the sorting bar.
Showing those texts in bigger letters beside headline doesn't make it look good.
Beside two views are different: organization profile and api catalog.
So in catalog, change text about filtered text should appear below the sort/action bar.

[brylie]

Thanks @Nazarah. That corresponds with the current code in this branch:

[marla-singer]

@brylie clean up i18n tag