elasticrest package added & code cleanup #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var date = moment.date(); // variable handling current date |
There was a problem hiding this comment.
How are months displayed? E.g. if the date range is from June 28th - July Nth?
|
Thanks for your work here and for clarifying the code with comments. |
brylie
added a commit
that referenced
this pull request
Jul 14, 2015
elasticrest package added & code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @apinf/developers please review this pull request. I have pretty much cleaned up everything as well as added
elasticrestpackage. SinceApiUmbrellaElasticclass with its method has been moved to separate package, justgetMonthAnalyticsfunction is left in that file.