Change in API name with proxy setting displays correct Api Name … #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brylie
reviewed
Mar 7, 2017
| Template.apiSelectPicker.helpers({ | ||
| // TODO: Update api Umbrella Admin case for multiple instance | ||
| apiName (id) { |
There was a problem hiding this comment.
Instead of using a template helper, lets make this a collection helper. Collection helper functions are attached to a collection document, e.g.:
// in the file: '/proxy_backends/collection/helpers.js'
ProxyBackends.helpers({
// Use full 'function' notation here:
apiName: function () {
// Get API ID
const apiId = this.apiId;
// Get API
const api = Apis.findOne(apiId);
// Return API Name
return api.name;
}
});Moving the apiName function to a collection helper, would result in the following code in your template:
<option value="{{ backend._id }}" >
{{ backend.apiName }}
</option>
brylie
reviewed
Mar 8, 2017
| import { Roles } from 'meteor/alanning:roles'; | ||
|
|
||
| // Apinf collection import(s) | ||
| import Apis from '/apis/collection'; | ||
| >>>>>>> 3553fa6d29346e17ec08ad99042869152d07f24e |
brylie
reviewed
Mar 8, 2017
| @@ -4,17 +4,17 @@ import { Template } from 'meteor/templating'; | |||
|
|
|||
| // Meteor contributed packages imports | |||
| import { FlowRouter } from 'meteor/kadira:flow-router'; | |||
| <<<<<<< HEAD | |||
|
|
|||
| ======= | |||
brylie
reviewed
Mar 8, 2017
| @@ -4,17 +4,17 @@ import { Template } from 'meteor/templating'; | |||
|
|
|||
| // Meteor contributed packages imports | |||
| import { FlowRouter } from 'meteor/kadira:flow-router'; | |||
| <<<<<<< HEAD | |||
brylie
reviewed
Mar 8, 2017
proxy_backends/collection/helpers.js
Outdated
|
|
||
| ProxyBackends.helpers({ | ||
| /* eslint object-shorthand: "error"*/ | ||
| /* eslint-env es6*/ |
There was a problem hiding this comment.
Try doing this instead:
// eslint-disable-next-line object-shorthandDoes that work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Api name having the proxy setting is changed , the new name was not reflecting in the dashboard dropdown list . Fixed this.
Closes #2092