Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api Catalogue sort with i18n support #2243

Merged
merged 4 commits into from
Mar 9, 2017
Merged

Api Catalogue sort with i18n support #2243

merged 4 commits into from
Mar 9, 2017

Conversation

manzapanza
Copy link
Contributor

Closes: #1303

@bajiat
Copy link
Contributor

bajiat commented Mar 7, 2017

@marla-singer Can I assign you as reviewer?

@manzapanza Is this work in progress or ready for review?

@manzapanza
Copy link
Contributor Author

@bajiat is ready for review

@marla-singer marla-singer self-assigned this Mar 7, 2017
@marla-singer
Copy link
Contributor

@manzapanza Add local-compare-polyfill in package.js as depence

@marla-singer
Copy link
Contributor

marla-singer commented Mar 7, 2017 •
edited

@bajiat @brylie How can I check that sort feature works as expected?
Is it a correct order?
joxi_screenshot_1488885084893

manzapanza
manzapanza commented Mar 7, 2017
View reviewed changes
package.json Outdated
@@ -22,6 +22,7 @@
"jquery": "^2.2.4",
"jquery-bbq": "^1.0.0",
"jquery.rateit": "^1.0.23",
"locale-compare-polyfill": "0.0.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marla-singer Is not this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. Change order, add it after js-yaml

@manzapanza
Copy link
Contributor Author

@marla-singer I ordered all packages by name

@bajiat
Copy link
Contributor

bajiat commented Mar 8, 2017

@marla-singer

One way to check is to see that if the sorting language is English, Ä is equivalent to A and Ö is equivalent to O (accents are ignored), while if Finnish is the sorting language, Ä is after Z and Ö is after Ä.

English

Aid
Äiteen API
Awesome API
....
ZED's API

Finnish

Aid
Awesome API
....
ZED's API
Äiteen API

@marla-singer
Copy link
Contributor

@bajiat Thanks for clarification. So it works as expected for English and Finnish

@marla-singer marla-singer merged commit 0045dc3 into develop Mar 9, 2017
@marla-singer marla-singer deleted the catalogue-i18n-sorting branch March 9, 2017 10:49
@brylie brylie modified the milestone: Sprint 38 Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marla-singer marla-singer marla-singer left review comments

Assignees

@marla-singer marla-singer

Labels
None yet
Projects
None yet
Milestone
Sprint 38
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manzapanza @bajiat @marla-singer @brylie