Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified User name regular expression #2272

Merged
merged 4 commits into from
Mar 10, 2017
Merged

Simplified User name regular expression #2272

merged 4 commits into from
Mar 10, 2017

Conversation

snittoor
Copy link

@snittoor snittoor commented Mar 10, 2017

Simplified the regular expression evaluation for username.These are the features:-
/^(?!-)(?!)[a-zA-Z0-9-]{3,15}$/;

  1. [a-zA-Z0-9-_] :- The username is alphanumeric and can begin with a number and can have a hypen or underscore
  2. (?!-)(?!_):- The username cannot begin with a hypen or underscore.
  3. {3,15}:- Minimum (3-15) in length.

Closes #1985
Closes #1963

@bajiat
Copy link
Contributor

bajiat commented Mar 10, 2017

@snittoor Is this PR work in progress or ready for review?

@snittoor
Copy link
Author

Ready for review

@brylie brylie merged commit 6ce8d36 into develop Mar 10, 2017
@brylie brylie deleted the userNameRegExp branch March 10, 2017 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants