RegEx messages #2276

55 · 2017-03-10T15:10:34Z

brylie · 2017-03-13T08:39:48Z

core/lib/simple_schema_config.js

+    { exp: SimpleSchema.RegEx.Email, msg: '[label] must be a valid e-mail address' },
+    { exp: proxyBasePathRegEx, msg: '[label] allowed characters: A-Z' },
+    { exp: apiBasePathRegEx, msg: '[label] allowed characters: A-Z' },
+    { exp: contactPhone, msg: '[label] allowed characters: A-Z' },


This does not correspond with the contactPhone regex.

brylie · 2017-03-13T08:40:30Z

I see this is a work-in-progress, so I will wait till it is closer for comments. It is looking good for a work-in-progress, though.

marla-singer · 2017-03-13T10:36:34Z

organizations/collection/regex.js

@@ -0,0 +1,3 @@
+// all numbers (0-9) , + , - , space ,/ are allowed and can appear anywhere in the phone numbers
+// e.g. 754-3010,(541) 754-3010,1-541-754-3010,1-541-754-3010,191 541 754 3010,(089) / 636-48018
+export const contactPhone = new RegExp(/^[0-9-+()/\s.]+$/);


Use export default

Using export default as

const contactPhone = new RegExp(/^[0-9-+()/\s.]+$/); export default contactPhone

gives me:

Error: Invalid definition for contact.phone field. W20170313-13:04:17.232(2)? (STDERR) at packages/aldeed_simple-schema.js:1429:13 W20170313-13:04:17.233(2)? (STDERR) at Function._.each._.forEach (packages/underscore.js:147:22) W20170313-13:04:17.233(2)? (STDERR) at [object Object].SimpleSchema (packages/aldeed_simple-schema.js:1426:5) W20170313-13:04:17.234(2)? (STDERR) at meteorInstall.organizations.collection.schema.js (organizations/collection/schema.js:12:24) W20170313-13:04:17.234(2)? (STDERR) at fileEvaluate (packages/modules-runtime.js:197:9) W20170313-13:04:17.235(2)? (STDERR) at require (packages/modules-runtime.js:120:16)

Of course, it gave. Use the correct import structure:

import contactPhone from '/path-to-library/';

Oh, thanks. Missed that.

55 · 2017-03-13T11:23:17Z

@apinf/developers can anybody help me with these regExs:

RegExp(/^\/[\w\-/\.:\?#@!\$&\*\+,;=\'\(\)]+\/$/);
RegExp(/^\/[\w\-/\.:\?#@!\$&\*\+,;=\'\(\)]*$/);

What are allowed characters here?

brylie · 2017-03-13T11:35:11Z

@apinf/developers can anybody help me with these regExs:
RegExp(/^\/[\w\-/\.:\?#@!\$&\*\+,;=\']+\/$/);
RegExp(/^\/[\w\-/\.:\?#@!\$&\*\+,;=\']*$/);

Basically, anything with a \ in front of it. I.e. if you remove all, but one, of the \ characters, you will be left with the character list.

@matleppa could you add a comment before those lines of code, to explain them in plain English?

shaliko · 2017-03-13T11:40:04Z

@brylie May be will be useful http://scriptular.com/

brylie · 2017-03-13T11:47:26Z

@shaliko thanks for the link. It seems like @NNN is wanting more of an explanation for what the regex does, as opposed to 'feeling around' to see what patterns it matches. To this end, Regex101 has an explanation tab that describes what a given regex is doing:

matleppa · 2017-03-13T13:53:01Z

[\w\-/\.:\?#@!\$&\*\+,;=\']
The characters indicated inside the square brackets are allowed followingly (sets are here separated with |):
\w allows: a-zA-Z0-9_ | following characters are allowed as such: /:#@!&,;= | following characters are allowed (but they must here be escaped with \ ): \- \. \? \$ \* \+ \'  so allowed characters are following: -.?$*+'()

55 · 2017-03-13T15:16:18Z

Open for suggestion on i18n token names and messages text.

Otherwise, ready for review.

brylie · 2017-03-14T08:21:17Z

core/lib/simple_schema_config.js

@@ -12,8 +12,8 @@ SimpleSchema.messages({
    { exp: SimpleSchema.RegEx.Id, msg: '[label] must be a valid alphanumeric ID' },
    { exp: SimpleSchema.RegEx.Domain, msg: '[label] must be a valid domain' },
    { exp: SimpleSchema.RegEx.Email, msg: '[label] must be a valid e-mail address' },
-    { exp: proxyBasePathRegEx, msg: 'Allowed characters for [label]: A-Z' },
-    { exp: apiBasePathRegEx, msg: 'Allowed characters for [label]: A-Z' },
+    { exp: proxyBasePathRegEx, msg: '[label] must begin and end with "/"' },


I can't recall if it is difficult/impossible to internationalize these regex validation messages. Since they are defined in a common folder, rather than a client folder, we may have encountered difficulties in the past.

brylie · 2017-03-14T08:23:48Z

@matleppa would you like to finish this PR review?

matleppa · 2017-03-14T10:53:57Z

Allowed alphanumeric characters and-.?$*+'()

There should also be mentioned underscore _
Also there should be a space between (and- --> and -)

matleppa · 2017-03-14T12:38:15Z

The end of my earlier comment was misleading.
All those mentioned characters are allowed, I just presented in three groups.

-.?$*+'()/:#@!&,;=

55 · 2017-03-14T12:41:08Z

@matleppa done

brylie · 2017-03-15T10:03:55Z

@matleppa it does not appear that this PR included code comments for the baseUrl regular expression. Please remember to add those comments, as they would clearly be helpful.

illya added 2 commits March 10, 2017 16:56

Simple Schema messages file

06eeb2b

Add regex messages for custom regex

14576f1

55 added the in progress label Mar 10, 2017

55 added this to the Sprint 38 milestone Mar 10, 2017

illya added 2 commits March 10, 2017 17:29

Move RegEx

01479bb

Include to SimpleSchema.messages

933643b

brylie reviewed Mar 13, 2017

View reviewed changes

brylie self-assigned this Mar 13, 2017

marla-singer reviewed Mar 13, 2017

View reviewed changes

illya added 3 commits March 13, 2017 13:02

Update messages

f17a8fd

Change export/import

d166b09

Updated messages

4911a9c

Update message

b43e7b9

i18n

9389d8f

55 added Ready for review and removed in progress labels Mar 13, 2017

brylie reviewed Mar 14, 2017

View reviewed changes

bajiat assigned matleppa Mar 14, 2017

Update messages

bb2b0ef

Updated allowed characters

00634f1

matleppa merged commit 2c86ffc into develop Mar 14, 2017

matleppa removed the Ready for review label Mar 14, 2017

matleppa deleted the feature/regex-messages branch March 14, 2017 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RegEx messages #2276

RegEx messages #2276

55 commented Mar 10, 2017 •

edited by bajiat

brylie Mar 13, 2017

brylie commented Mar 13, 2017

marla-singer Mar 13, 2017

55 Mar 13, 2017

marla-singer Mar 13, 2017 •

edited

55 Mar 13, 2017

55 commented Mar 13, 2017

brylie commented Mar 13, 2017 •

edited

shaliko commented Mar 13, 2017

brylie commented Mar 13, 2017

matleppa commented Mar 13, 2017 •

edited by 55

55 commented Mar 13, 2017 •

edited

brylie Mar 14, 2017

brylie commented Mar 14, 2017

matleppa commented Mar 14, 2017

matleppa commented Mar 14, 2017

55 commented Mar 14, 2017

brylie commented Mar 15, 2017

RegEx messages #2276

RegEx messages #2276

Conversation

55 commented Mar 10, 2017 • edited by bajiat

brylie Mar 13, 2017

Choose a reason for hiding this comment

brylie commented Mar 13, 2017

marla-singer Mar 13, 2017

Choose a reason for hiding this comment

55 Mar 13, 2017

Choose a reason for hiding this comment

marla-singer Mar 13, 2017 • edited

Choose a reason for hiding this comment

55 Mar 13, 2017

Choose a reason for hiding this comment

55 commented Mar 13, 2017

brylie commented Mar 13, 2017 • edited

shaliko commented Mar 13, 2017

brylie commented Mar 13, 2017

matleppa commented Mar 13, 2017 • edited by 55

55 commented Mar 13, 2017 • edited

brylie Mar 14, 2017

Choose a reason for hiding this comment

brylie commented Mar 14, 2017

matleppa commented Mar 14, 2017

matleppa commented Mar 14, 2017

55 commented Mar 14, 2017

brylie commented Mar 15, 2017

55 commented Mar 10, 2017 •

edited by bajiat

marla-singer Mar 13, 2017 •

edited

brylie commented Mar 13, 2017 •

edited

matleppa commented Mar 13, 2017 •

edited by 55

55 commented Mar 13, 2017 •

edited