Ui for normalize metadata #2278

marla-singer · 2017-03-13T10:32:17Z

Closes #2185
Closes #2064
Closes #855

Remove Orgazanition block from Metadata tab
Add validation for Phone & Email field
Edit label (capitalize)
Add organization name in API page header

marla-singer · 2017-03-13T10:58:33Z

@brylie I've done fetch organization data via collection helper. But I have an open question:

If API metadata doesn't exist and a user is connection API to an organization. What to do?

brylie · 2017-03-13T11:30:45Z

If API metadata doesn't exist and a user is connection API to an organization. What to do?

One idea, would be to display the related Organization somewhere on the API Profile page (e.g. in the header). That way, we can use the collection helper to retrieve the Organization document, and display the organization name.

In effect, we are fully removing the Organization from the Metadata feature/view.

@Nazarah and @bajiat, what are your thoughts? Do we have some time available to add the Organization details to the API Profile wireframe?

marla-singer · 2017-03-13T12:10:44Z

@brylie We can leave it as Enhancement. Now I implemented it with minimal trigger actions.

brylie · 2017-03-13T12:26:39Z

metadata/collection/schema.js

@@ -24,10 +24,13 @@ ApiMetadata.schema = new SimpleSchema({
  },
  'contact.phone': {
    type: String,
+    // TODO: used constant contactPhone
+    regEx: /^[0-9-+()/\s.]+$/,


Please describe this regular expression in plain English. We are currently reviewing regular expressions, so we can provide human friendly error messages.

After merging 2276 PR I will replace it to constant

brylie · 2017-03-13T12:27:54Z

organization_apis/client/form/autoform.js

+      // Make sure API metadata doesn't exists
+      if (!apiMetadata) {
+        // Create a new document
+        ApiMetadata.insert({ apiId });


Why do we need to create a dummy document?

Lets try to find a solution that doesn't create 'empty' documents.

It isn't empty. You can it perceive like a container for displaying organization information.

Ah, I think I see the problem. Rather than creating an empty document, just so we can use collection helper from the API Metadata collection, simply use the existing Apis.organization() helper.

Hm. I need to think about it. I have an idea

Kool. Remember to just keep it simple.

marla-singer · 2017-03-13T12:56:17Z

@brylie If API Metadata doesn't exists, it will be look so:

marla-singer · 2017-03-13T12:58:58Z

But we need to think up something about text "No Metadata found".
My idea is

If API is connected to an organization, don't display text for ordinary users and show text "No contact or service is here. You can add using button Edit metadata"
if API is not connected to an organization then display "No Metadata found" as before. Text must be improved

brylie · 2017-03-13T13:02:20Z

@marla-singer lets just see if we can move the organization details to the API Profile. That would sidestep this whole issue.

cc: @bajiat @Nazarah

Nazarah · 2017-03-14T06:51:59Z

agree with @brylie about showing organization information in API profile header.
It takes one extra click for an user to find out if it has any organization associated.
When there is no connection, we can simply hide organization metadata from profile header.

bajiat · 2017-03-14T08:08:49Z

I think it is ok to show organization name in the API profile header. Long term I think APIs should either be added by an organization or a person. This would mean that we could namespace the APIs with either username or organization name. This probably requires rethinking how we add APIs.

But if there are any other details in the Metadata tab for organization, I'm not sure they should be added anywhere else than Metadata. Unless you have a concrete suggestion where we would have room for more details than organization name.

If the Metadata tab contains information about organization, is it really necessary to show "No metadata found". Even though technically the remaining information comes from Metadata document, does the user care about that?

marla-singer · 2017-03-14T08:16:11Z

@bajiat @Nazarah I need wireframe for that

brylie · 2017-03-14T09:28:40Z

@marla-singer I just got approval from @bajiat to simply add the organization name to the API Profile page, in a way that we see fit. We will get review from @bajiat and @Nazarah when we have a working example.

brylie · 2017-03-14T09:43:16Z

Here is an example wireframe:

marla-singer · 2017-03-14T09:43:56Z

I thought so

marla-singer · 2017-03-14T09:56:39Z

@brylie @Nazarah @bajiat

The image size became bigger. It was 50 px, I did 80 px

Nazarah · 2017-03-14T09:59:12Z

@marla-singer : can we reposition the star-ratings a bit down and then position Organization data there?
I am not liking the look and feel of owner and organization information coming side by side.
Two information are different and they should have different focus on user's eyes, not creating conflict in attention.

marla-singer · 2017-03-14T10:12:27Z

The API profile header is fact-laden 😕

Nazarah · 2017-03-14T10:28:37Z

I'd like to go with the following design:

The changes that this screen needs is to have the same logo of organization that we show in navbar.
The name should be a link to the organization profile itself.
Also Star-rating should appear below organization name.

marla-singer · 2017-03-14T11:30:27Z

marla-singer · 2017-03-14T11:32:44Z

But If API is not connected to an organization, it looks like

marla-singer · 2017-03-14T12:35:28Z

@bajiat Remove or not Organization block from Metadata tab at all?

bajiat · 2017-03-15T10:08:01Z

@marla-singer Go ahead and remove organization from Metadata

marla-singer · 2017-03-15T10:46:29Z

@brylie Ready for review

marla-singer added 5 commits March 13, 2017 13:30

add organizationId after insert/update apiMetadata

aa2e1e9

Name as link, add url

5f1d2a2

Change order

68a500a

Add helper for handled data

1340e39

Use helper

79cb9d4

marla-singer added this to the Sprint 38 milestone Mar 13, 2017

marla-singer added the in progress label Mar 13, 2017

marla-singer added 4 commits March 13, 2017 13:38

Edit label

4453a38

Edit label (capitalize)

b418eb5

Add regEx validation for email and phone field

3cccfc9

Lint

4bf0591

marla-singer added 2 commits March 13, 2017 14:57

Delete actions from onSuccess hook

921f0d0

Lint

3c81909

marla-singer added the Ready for review label Mar 13, 2017

marla-singer requested a review from brylie March 13, 2017 12:11

brylie suggested changes Mar 13, 2017

View reviewed changes

brylie removed the Ready for review label Mar 13, 2017

Show Organization block as separated block

128df23

marla-singer force-pushed the feature/ui-for-normalize-metadata branch from c15757f to 128df23 Compare March 13, 2017 13:04

brylie self-assigned this Mar 13, 2017

marla-singer added 5 commits March 14, 2017 15:24

Change img size to 80px

6755587

Add organization name, change mark up

bc66b4b

Style for new block

f266a39

Fix markup

06a8bac

Fix markup

d9c77a6

marla-singer added 2 commits March 15, 2017 10:37

Merge branch 'develop' into feature/ui-for-normalize-metadata

b12c594

Use constant intead of regex for contact phone

3548525

marla-singer added 6 commits March 15, 2017 13:13

Remove organizationId field

84e51f4

Remove emun of fields

89e0742

Remove useless helper

ad4c6bb

Remove useless collection helper

d6ba741

Remove organization block from Metadata tab

38985af

Lint

0b56af8

marla-singer added the Ready for review label Mar 15, 2017

brylie merged commit e00d02a into develop Mar 15, 2017

brylie deleted the feature/ui-for-normalize-metadata branch March 15, 2017 11:31

brylie removed in progress Ready for review labels Mar 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ui for normalize metadata #2278

Ui for normalize metadata #2278

marla-singer commented Mar 13, 2017 •

edited

marla-singer commented Mar 13, 2017 •

edited

brylie commented Mar 13, 2017 •

edited

marla-singer commented Mar 13, 2017

brylie Mar 13, 2017

marla-singer Mar 13, 2017

brylie Mar 13, 2017

brylie Mar 13, 2017

marla-singer Mar 13, 2017

brylie Mar 13, 2017 •

edited

marla-singer Mar 13, 2017

brylie Mar 13, 2017

marla-singer commented Mar 13, 2017

marla-singer commented Mar 13, 2017 •

edited

brylie commented Mar 13, 2017 •

edited

Nazarah commented Mar 14, 2017

bajiat commented Mar 14, 2017

marla-singer commented Mar 14, 2017

brylie commented Mar 14, 2017

brylie commented Mar 14, 2017

marla-singer commented Mar 14, 2017

marla-singer commented Mar 14, 2017

Nazarah commented Mar 14, 2017

marla-singer commented Mar 14, 2017

Nazarah commented Mar 14, 2017

marla-singer commented Mar 14, 2017

marla-singer commented Mar 14, 2017

marla-singer commented Mar 14, 2017

bajiat commented Mar 15, 2017

marla-singer commented Mar 15, 2017

Ui for normalize metadata #2278

Ui for normalize metadata #2278

Conversation

marla-singer commented Mar 13, 2017 • edited

marla-singer commented Mar 13, 2017 • edited

brylie commented Mar 13, 2017 • edited

marla-singer commented Mar 13, 2017

brylie Mar 13, 2017

Choose a reason for hiding this comment

marla-singer Mar 13, 2017

Choose a reason for hiding this comment

brylie Mar 13, 2017

Choose a reason for hiding this comment

brylie Mar 13, 2017

Choose a reason for hiding this comment

marla-singer Mar 13, 2017

Choose a reason for hiding this comment

brylie Mar 13, 2017 • edited

Choose a reason for hiding this comment

marla-singer Mar 13, 2017

Choose a reason for hiding this comment

brylie Mar 13, 2017

Choose a reason for hiding this comment

marla-singer commented Mar 13, 2017

marla-singer commented Mar 13, 2017 • edited

brylie commented Mar 13, 2017 • edited

Nazarah commented Mar 14, 2017

bajiat commented Mar 14, 2017

marla-singer commented Mar 14, 2017

brylie commented Mar 14, 2017

brylie commented Mar 14, 2017

marla-singer commented Mar 14, 2017

marla-singer commented Mar 14, 2017

Nazarah commented Mar 14, 2017

marla-singer commented Mar 14, 2017

Nazarah commented Mar 14, 2017

marla-singer commented Mar 14, 2017

marla-singer commented Mar 14, 2017

marla-singer commented Mar 14, 2017

bajiat commented Mar 15, 2017

marla-singer commented Mar 15, 2017

marla-singer commented Mar 13, 2017 •

edited

marla-singer commented Mar 13, 2017 •

edited

brylie commented Mar 13, 2017 •

edited

brylie Mar 13, 2017 •

edited

marla-singer commented Mar 13, 2017 •

edited

brylie commented Mar 13, 2017 •

edited