Pages via URL #2283
Pages via URL #2283
Conversation
|
@apinf/developers Ready for review |
core/client/lib/router.js
Outdated
| // There are specific cases that this reruns | ||
|
|
||
| // Make sure the roles subscription is ready & FlowRouter hasn't initialized already | ||
| if (Roles.subscription.ready() && !FlowRouter._initialized) { |
There was a problem hiding this comment.
Is there a more FlowRouter specific way to wait for the Roles subscription? E.g. an onInitialize or beforeInitialize hook?
There was a problem hiding this comment.
FlowRouter limits reactive data sources to a single run; when it is first called.
It might not be the case that we can check for the Roles subscription in a different way. I just want to double check.
There was a problem hiding this comment.
@brylie If you can find another way - you're welcome. I added the link to article in description box that I found
There was a problem hiding this comment.
After scanning the FlowRouter docs, I can't come up with a different proposal for this code.
One thing that would be helpful, since this is a very unique situation, is to add a multi-line comment describing the need for the Tracker.autorun function. What problem is it solving?
core/client/lib/router.js
Outdated
| // There are specific cases that this reruns | ||
|
|
||
| // Make sure the roles subscription is ready & FlowRouter hasn't initialized already | ||
| if (Roles.subscription.ready() && !FlowRouter._initialized) { |
There was a problem hiding this comment.
After scanning the FlowRouter docs, I can't come up with a different proposal for this code.
One thing that would be helpful, since this is a very unique situation, is to add a multi-line comment describing the need for the Tracker.autorun function. What problem is it solving?
|
@brylie Add the comment. Is it full enough? |
Closes #2222
Closes #2281
Meteor.user()._id;toMeteor.userId(). It did the stack overflow