Updated Finnish translations #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/lib/i18n/fi.i18n.json
Outdated
| @@ -556,7 +240,7 @@ | |||
| "dashboardDataTable_timeStamp": "P\u00e4iv\u00e4ys", | |||
| "dashboardDataTable_title": "Analytiikka", | |||
| "dashboardDataTable_pageCount": "Sivu", | |||
| "dashboardCharts_placeholder_noDataFound": "Tietoja ei l\u00f6ytynyt. Kokeile muuttaa suodatusvaihtoehtoja n\u00e4hd\u00e4ksesi analytiikkadataa.", | |||
| "dashboardCharts_placeholder_noDataFound": "Tietoja ei l\u00f6ytynyt. <br\/> Kokeile muuttaa suodatusvaihtoehtoja n\u00e4hd\u00e4ksesi analytiikkadataa.", | |||
There was a problem hiding this comment.
@bajiat Delete <br\/> tag
core/lib/i18n/fi.i18n.json
Outdated
| "organizationProfile_bigText_apisCount": "Rajapinnat", | ||
| "organizationProfileHeader_editButton_text": "Muokkaa", | ||
| "organizationProfileHeader_tabs_apis": "Rajapinnat", | ||
| "organizationProfileHeader_tabs_settings": "Asetukset", | ||
| "organizationProfile_smallText_apisCount": "(Rajapintoja: %s)", | ||
| "organizationProfile_smallText_apisCount": "", | ||
| "organizationProfile_smallText_apisCount_plural": "", |
There was a problem hiding this comment.
@bajiat Why did you leave it as empty strings? It should be like for apiCatalog_apisCount and apiCatalog_apisCount_plural
|
Another things look good |
|
Are the lines 445 and 446 ok now? Those have somehow managed to skip my attention. We use a tool for translation and proofreading and I remember thinking that the apicount was cleverly solved, but I can't remember even seeing lines 445 and 446. |
|
@bajiat Yes, now it is ok. Do I merge it or do you usually merge that PRs? |
|
@marla-singer Please merge this and thank you for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2175