Hotfix/fix lint

[brylie]

Don't hit me 😨

[marla-singer]

@brylie It doesn't work. Now if list contains proxy backend with non-existent API then there is an empty place

[brylie]

We need to clean up that proxy backend. Please refer to the discussion in the other PR, where we tried doing due diligence and decided to go with the basic fix.

This PR is a lint fix.

[brylie]

Well, it does work, but there may be corrupted data on the server. How did you test?

[marla-singer]

How did you test?

@brylie Create Proxy Backend with non-existent API ID. The same case as apinf.io has

[mauriciovieira]

@marla-singer The logic is unaltered. So this empty name should happen also before this hotfix.

[brylie]

Create Proxy Backend with non-existent API ID. The same case as apinf.io has

Steps to reproduce?

Remember, there were three of us discussing this issue. We found out there were migration problems. I tested the cascading delete successfully.

It might just be a botched migration that caused inconsistent data, but the patch will prevent the original issue of the Dashboard being blank.

[marla-singer]

@mauriciovieira I missed this bug in this PR #2540

[mauriciovieira]

I mean, @marla-singer, before this return here, it was returning undefined anyways.

[brylie]

What should this code block look like @mauriciovieira?

[marla-singer]

@brylie But now apinf.io contains Proxy Backend document with non-existent API ID. And because of that Dashboard page is empty

[brylie]

In the case of the non-existant API, the data needs to be cleaned up. This hotfix did not address that issue, by design.

We can continue the work in a different pull request, but will need steps to reproduce the data inconsistency other than manually creating a proxy backend with malformed API ID.

[brylie]

But now apinf.io contains Proxy Backend document with non-existent API ID. And because of that Dashboard page is empty

The whole dashboard is empty? We haven't deployed this hotfix there yet, have we?

[mauriciovieira]

Ah, I see https://github.com/apinf/platform/pull/2540/commits was not checked by travis.

[brylie]

Jep, and I wasn't reading my lint messages closely. My bad.

[marla-singer]

@mauriciovieira What do you think? This PR fixes ESlint error but it seems that found bug can repeat on apinf.io

[mauriciovieira]

@brylie, @marla-singer I think that if the problem of #2528 is still there, even after #2540, we must not amend things. We must revert c3cb04a

[mauriciovieira]

But if #2540 really closes #2528, this hotfix is appropriate here.

[brylie]

I think that if the problem of #2528 is still there

Based on what? How can we reproduce?

Our strongest hypothesis so far is that it was a failed migration, please review the comments:

• apinf.io dashboard empty #2528 (comment)
• apinf.io dashboard empty #2528 (comment)'
• apinf.io dashboard empty #2528 (comment)

[mauriciovieira]

@brylie I see your point. @marla-singer I agree with @brylie.

[brylie]

Thank you @mauriciovieira. We can definitely continue researching this issue, but it is just not clear to me what to do differently.

@marla-singer thank you very much for being so thorough with your reviews :-)

[mauriciovieira]

The problem we face is that we have no clear answer as to how the data became inconsistent

I wonder if it's related to migration changing #2431 (comment)

[mauriciovieira]

I did merge master back to develop 1eaa1ed after this hotfix was applied to master