-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bookmarking #267
Feature/bookmarking #267
Conversation
@apinf/developers please review this. |
Template.favourite.created = function () { | ||
// subscribe to user bookmarks | ||
this.subscribe('myApiBookmarks'); | ||
this.subscribe('myBookmarkedApis'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This subscription may be unnecessary. Try commenting out and testing again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For readability and understanding, rename the publications to be more clear. E.g. 'userApiBookmarks' and 'userBookmarkedApiBackends'.
|
Closing #232