Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic for "Last 24 hours" option of date range picker #3054

Closed
wants to merge 1 commit into from

Conversation

marla-singer
Copy link
Contributor

Closes #3020

Changes

Describe your changes here as a bulleted list:

  • Update query parameter "timeframe". Now it has a format as "7-day" that contains timeframe value and granularity
  • When a user selects "Last 24 hours" that the charts have labels as "hour"

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @matleppa @mauriciovieira

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

 - Update query parameter "timeframe". Now it has a format as "7-day" that contains timeframe value and granularity
 - When a user selects "Last 24 hours" that the charts have labels as "hour"
@marla-singer
Copy link
Contributor Author

PR is not ready for review. I'd like to include also #3052 task

@matleppa
Copy link
Member

matleppa commented Oct 18, 2017

I guess this PR is to be closed, because of the coming changes in way storing the traffic information, which causes changes in dashboard functionality, right?

@bajiat
Copy link
Contributor

bajiat commented Oct 24, 2017

@marla-singer What is your opinion? Should we close this as @matleppa suggested in the previous comment?

@marla-singer
Copy link
Contributor Author

@bajiat Yes

@bajiat bajiat closed this Oct 24, 2017
@ghost ghost removed the in progress label Oct 24, 2017
@preriasusi preriasusi deleted the bugfix/last-24-hours branch August 29, 2018 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants