Feature/filtering data by api #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: client/charts/charts.js
Conflicts: .meteor/versions
| match_all: {} | ||
| } | ||
|
|
||
| } else if (Roles.userIsInRole(loggedInUser, ['owner'])) { |
There was a problem hiding this comment.
This is unnecessary, as we may not define the user role 'owner'. The current plan is to add an 'owners' field to each API backend, containing an array of owner IDs or emails.
|
This looks good, but has unnecessary logic for the API Owner role. Please remove the else if statement, and we can add it later based on the owners field (not yet implemented). |
marla-singer
added a commit
that referenced
this pull request
Feb 6, 2017
Modify texts related to connecting APIs to organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apinf/developers Please review this PR. #181 - related issue. All visible analytics data is filtered by current user's api key.