Feature/chart markup #320
Merged
Feature/chart markup #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still couple things needed to be fixed. WIP tag added |
|
This can be merged now. @apinf/developers |
| @@ -1,5 +1,10 @@ | |||
| <template name="filterData"> | |||
| <h3>Filter by:</h3> | |||
|
|
|||
| <div class="box box-primary"> | |||
There was a problem hiding this comment.
Check indentation on this file. There may be a semantic error, indicated by the odd indentation structure.
|
Everything seems good, except the odd indentation structure in filter.html. Update the file indentation and double check the opening/closing tag pairs as well as nesting. |
|
@brylie how does it look now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outlook after styling:
