Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Add admin toggle to hide development features #3341

Merged

Conversation

deligence-dharmendra
Copy link
Contributor

@deligence-dharmendra deligence-dharmendra commented Jan 23, 2018

Closes #3338

Changes

  • changes in language and setting HTML file
  • added a new field in the settings schema named as "developmentFeatures"

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @marla-singer @matleppa

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@marla-singer
Copy link
Contributor

Will look at it tomorrow

Copy link
Contributor

@marla-singer marla-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No errors, works fine

@marla-singer marla-singer merged commit 6565dad into develop Jan 25, 2018
@ghost ghost removed the Ready for review label Jan 25, 2018
@marla-singer marla-singer added this to the Sprint 62 milestone Jan 25, 2018
@marla-singer marla-singer deleted the feature/add-admin-toggle-to-hide-development-features branch January 30, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants