Add Search box on the Dashboard page #3367
Conversation
- Add input - Display count of found result - Display No APIs found if it is
ghost
assigned 
| </h1> | ||
| </div> | ||
| <div class="col-xs-12 col-sm-4"> | ||
| <input type="text" class="form-control pull-right" placeholder="Search" id="search-box"> |
There was a problem hiding this comment.
About the search condition input:
-
Placeholder: instead of plain text, make it localizable
e.g.
placeholder="{{_ 'searchField_placeholder' }}"> -
Because the search is not incremental, but it needs a Enter key to be pressed, there needs to be a visible [Search] button on the right hand side of input field. That way the user gets a clue, what needs to be done.
-
I think that the magnification glass symbol should also be included within th input field.
There was a problem hiding this comment.
1 and 3 points are done
| }); | ||
|
|
||
| Template.dashboardPage.events({ | ||
| 'change #search-box': (event, templateInstance) => { |
There was a problem hiding this comment.
Could we get more convenient user experience with incremental search, if we used here keyup instead of change?
There was a problem hiding this comment.
Change event type to keyup. In this case it doesn't need to be a visible [Search] button on the right hand side of input field
|
@matleppa The changes done |
Changes
Closes #2752
Developer checklist
This checklist is to be completed by the PR developer:
Reviewer checklist
Reviewed by: @matleppa @anarva
This list is to be completed by the pull request reviewer: