Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Eslint errors on the develop branch #3446

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Conversation

marla-singer
Copy link
Contributor

@marla-singer marla-singer commented Mar 26, 2018

  • Current the develop branch has the errors that relate to eslint
  • Update yarn.lock to fix tests

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned marla-singer Mar 26, 2018
@ghost ghost added the in progress label Mar 26, 2018
@55 55 self-requested a review March 27, 2018 10:48
@marla-singer marla-singer merged commit 16ecda5 into develop Mar 27, 2018
@ghost ghost removed the in progress label Mar 27, 2018
@marla-singer marla-singer deleted the bugfix/fix-eslint-error branch March 27, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants